Run Integration tests on EKS #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciovasquezbernal
requested review from
alban,
eiffel-fl and
mqasimsarfraz
as code owners
eiffel-fl
reviewed
Feb 9, 2024
| shell: bash | ||
| run: | | ||
| echo "CLUSTER_NAME=${{ env.AWS_EKS_CLUSTER_PREFIX }}${{ matrix.arch }}-${RANDOM}" >> $GITHUB_ENV | ||
| - name: Install eksctl |
There was a problem hiding this comment.
It does not exist a GitHub action to do so?
There was a problem hiding this comment.
I see there is https://github.com/moia-oss/setup-eksctl, but I prefer to do this here rather than introducing a dependency on a non very popular action.
| if: always() | ||
| shell: bash | ||
| run: | | ||
| eksctl delete cluster --name ${{ env.CLUSTER_NAME }} --region ${{ env.AWS_REGION }} |
There was a problem hiding this comment.
For AKS, we use --no-wait to run it async.
Is this possible on EKS?
There was a problem hiding this comment.
Nice, they have --wait=false, let me try it.
mauriciovasquezbernal
force-pushed
the
citest/enable-eks-test
branch
from
f9fc22e
to
d4e035a
Compare
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
had a problem deploying
to
aks
GitHub Actions
Failure
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
had a problem deploying
to
aks
GitHub Actions
Failure
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
had a problem deploying
to
aks
GitHub Actions
Failure
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
had a problem deploying
to
aks
GitHub Actions
Failure
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
had a problem deploying
to
aks
GitHub Actions
Failure
mqasimsarfraz
approved these changes
Feb 13, 2024
Check another possible error message returned by wget. Fixes: 29bede7 ("integration: Add test for sched cls programs") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Same as 65f0d30 ("remove arm64 workaround in exec tracer") for this tracer. It was causing the container hook to fail loading in EKS on arm64. It made the integration test fail because new containers weren't detected fast enough. Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Introduce a new constant for this case and skip a couple of tests when it's detected. Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
ig is not strictly needed by those jobs, so remove it as a dependency. Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
force-pushed
the
citest/enable-eks-test
branch
from
d4e035a
to
2103572
Compare
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
had a problem deploying
to
aks
GitHub Actions
Failure
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
mauriciovasquezbernal
temporarily deployed
to
aks
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables integration tests running on EKS. It also includes some fixes to make them work, specially on arm64.
OpenID Connect is used to authenticate Github Actions with AWS, hence no secrets are needed to be configured in the repository.
Sample runs can be found in:
Fixes #783