Fix auto-mount-filesystems #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blanquicet
approved these changes
Feb 20, 2024
| err = unix.Statfs(path, &statfs) | ||
| if err != nil { | ||
| return mountsSuggested, fmt.Errorf("statfs %s: %w", path, err) | ||
| if err := unix.Statfs(path, &statfs); err != nil { |
There was a problem hiding this comment.
nit: This indeed solves the issue, but I would prefer to avoid using named return values so that we don't end up with this shadowing.
If there is an error calling statfs on the path, for instance, it doesn't exist, the logic should continue without erroring out to suggest using "--auto-mount-filesystems" Fixes: 073bcd0 ("auto-mount-filesystems: add alternative path for tracefs") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
force-pushed
the
mauricio/fix-mount-workaround
branch
from
65c9648
to
c0b6291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an error calling statfs on the path, for instance, it doesn't exist, the logic should continue without erroring out to suggest using "--auto-mount-filesystems"
Fixes: 073bcd0 ("auto-mount-filesystems: add alternative path for tracefs")
Testing
Create a privileged container without mounting tracefs nor debugfs from the host:
$ docker run --privileged -it --rm -v $(pwd):/ig ubuntu:22.04 bashBefore this PR
$ /ig/ig trace exec --host error: statfs /sys/kernel/debug/tracing: no such file or directoryAfter this PR