Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebpf-builder: update to libbpf v1.3.0 #2532

Merged
merged 1 commit into from
Mar 7, 2024
Merged

ebpf-builder: update to libbpf v1.3.0 #2532

merged 1 commit into from
Mar 7, 2024

Conversation

alban
Copy link
Member

@alban alban commented Feb 22, 2024

Inspektor Gadget does not use the userspace parts of libbpf, but only the headers included in gadgets' ebpf code.

libbpf v1.3.0 release notes include:

BPF-side features and APIs

  • triple-underscore flavors for kfunc relocation: like with CO-RE structs ___.* suffix is ignored when kfunc relocations are resolved;
  • __percpu_kptr macro definition in bpf_helpers.h;
  • support for exception callbacks, use attribute(btf_decl_tag("exception_callback:<func_name>")) to specify exception callback for a program;

Copy link
Member

@eiffel-fl eiffel-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK from code point of view.
Did you try running make ebpf-objects? I only see there is one updated file?

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM from code inspection. But needs a rebase before going in. Approving in any case.

@alban
Copy link
Member Author

alban commented Mar 4, 2024

Yes, I rebuilt in this way:

docker build -f Dockerfiles/ebpf-builder.Dockerfile -t ghcr.io/inspektor-gadget/ebpf-builder:alban_new_libbpf .
EBPF_BUILDER=ghcr.io/inspektor-gadget/ebpf-builder:alban_new_libbpf make ebpf-objects

Inspektor Gadget does not use the userspace parts of libbpf, but only
the headers included in gadgets' ebpf code.

libbpf v1.3.0 release notes include:

> BPF-side features and APIs
> * triple-underscore flavors for kfunc relocation: like with CO-RE structs ___.* suffix is ignored when kfunc relocations are resolved;
> * __percpu_kptr macro definition in bpf_helpers.h;
> * support for exception callbacks, use __attribute__(btf_decl_tag("exception_callback:<func_name>")) to specify exception callback for a program;

Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
@alban alban merged commit 2da5588 into main Mar 7, 2024
59 checks passed
@alban alban deleted the alban_new_libbpf branch March 7, 2024 07:49
@alban
Copy link
Member Author

alban commented Mar 7, 2024

I merged it and built/pushed the new version of ghcr.io/inspektor-gadget/ebpf-builder:latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants