pkg/gadgets: Fixes trace bind for kernel 6.6 and younger. #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel-fl
requested review from
alban and
mauriciovasquezbernal
as code owners
In kernel 6.6, the bitfields in struct inet_sock where moved to a dedicated flag [1, 2, 3, 4]. To adapt to this change, a CO-RE solution was proposed in iovisor/bcc for bindsnoop [5]. This is a good solution, as it will work on kernel backporting the patches. This commit adapts the bindsnoop solution to Inspektor Gadget. Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com> [1]: https://lore.kernel.org/all/20230816081547.1272409-1-edumazet@google.com/ [2]: torvalds/linux@3f7e753206bb [3]: torvalds/linux@ca571e2eb7eb [4]: torvalds/linux@4bd0623f04ee [5]: iovisor/bcc@a55b5a0c920f
eiffel-fl
force-pushed
the
francis/trace-bind-6.6
branch
from
dcfcda6
to
640cf0f
Compare
mauriciovasquezbernal
approved these changes
Mar 11, 2024
Thank you for the review!
What do you mean by |
Ah, I thought they also have this issue. Nothing to be done then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kernel 6.6, the bitfields in struct inet_sock where moved to a dedicated flag [1, 2, 3, 4].
To adapt to this change, a CO-RE solution was proposed in iovisor/bcc for bindsnoop 5.
This is a good solution, as it will work on kernel backporting the patches.
This commit adapts the bindsnoop solution to Inspektor Gadget.