dns: Add support for IPv6 and variable length IPv4 headers. #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: d772f2e ("dns: Parse DNS packet in user space") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
1 task
blanquicet
approved these changes
Mar 6, 2024
Comment on lines
+118
to
+119
| proto = load_byte(skb, | ||
| ETH_HLEN + offsetof(struct iphdr, protocol)); |
There was a problem hiding this comment.
nit: This could be taken from iph->protocol
There was a problem hiding this comment.
I'd prefer to handle this on a similar PR to #2579.
alban
reviewed
Mar 6, 2024
1 task
Support IPv6 nameservers and extend parsing logic to support IPv4 options. Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
force-pushed
the
mauricio/add-ipv6-support-dns
branch
from
f43786f
to
67bfa60
Compare
I fear it's too complicated. We'll need to have a cluster with ipv6 enabled, and/or being able to run containers with ipv6. I can open an issue to handle this later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support IPv6 nameservers and extend parsing logic to support IPv4 options.