pkg/oci: Few cleanups and improvements to make code clearer #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
GetIndex doesn't need to be exposed as we have a grapper for this that returns directly the manifest for the host: GetManifestForHost. Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
getContentFromDescriptor and GetContentFromDescriptor do the same but one returns []byte and the other a ReadCloser. Make clear the difference in the name. Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
Size will never be 0 because we are using the DescriptorEmptyJSON when the metadata file is not provided. And DescriptorEmptyJSON has size 2. Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
blanquicet
requested review from
flyth
and removed request for
alban and
mauriciovasquezbernal
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't change the integration with other modules, so rebasing refactoring on top of this is fast-forward. cc @flyth