tree-wide: Fix imports grouping and add lint target #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add goimports linter to make sure all imports are grouped in the same way in all the repository. Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
requested review from
alban,
blanquicet and
mqasimsarfraz
as code owners
eiffel-fl
approved these changes
Mar 19, 2024
| # A comma-separated list of prefixes, which, if set, checks import paths | ||
| # with the given prefixes are grouped after 3rd-party packages. | ||
| # Default: "" | ||
| local-prefixes: github.com/inspektor-gadget/inspektor-gadget |
There was a problem hiding this comment.
I am wondering if there is no such variable like ${{ github.repository }}, this would make it portable but I am doubtful it exists.
There was a problem hiding this comment.
But even forks of the IG repo still use "github.com/inspektor-gadget/inspektor-gadget" in the Golang code. Forks might be used via a "replace" command in go.mod but the import paths remain the same as upstream.
There was a problem hiding this comment.
Sort of, if you modified something to a given package, you may want to use github.com/your_fork/inspektor-gadget.
But I agree this would not be often the case, hence my approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add goimports linter to make sure all imports are grouped in the same way in all the repository.