Update gadgets metadata and keep them in sync #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to run 'make' with custom build parameters, such as --update-metadata. Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
alban
requested review from
mauriciovasquezbernal,
eiffel-fl and
mqasimsarfraz
as code owners
4 tasks
eiffel-fl
approved these changes
Mar 25, 2024
Comment on lines
+372
to
+383
| build-official-image-based-gadgets: | ||
| name: Build gadgets | ||
| # level: 1 | ||
| needs: build-ig | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Check if metadata files are updated | ||
| run: | | ||
| GADGET_BUILD_PARAMS="--update-metadata" make build-gadgets | ||
| git diff --exit-code HEAD -- | ||
|
|
There was a problem hiding this comment.
What about this approach to avoid building the gadgets twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gadgets metadata and keep them in sync
This PR updates the gadgets metadata (gadget.yaml) and adds a CI check that it stays in sync.
How to use
A gadget metadata can be updated manually with:
Testing done
The CI.