Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: port uprobe support #2657

Merged
merged 1 commit into from
Mar 28, 2024
Merged

refactoring: port uprobe support #2657

merged 1 commit into from
Mar 28, 2024

Conversation

flyth
Copy link
Member

@flyth flyth commented Mar 28, 2024

This commit from @mauriciovasquezbernal ports basic uprobe support to the new architecture / eBPF operator.

@alban
Copy link
Member

alban commented Mar 28, 2024

@i-Pear Could you review this PR? Thanks!

@i-Pear
Copy link
Contributor

i-Pear commented Mar 28, 2024

Looks good to me, thanks. The code here is identical to #2580.

@i-Pear
Copy link
Contributor

i-Pear commented Mar 28, 2024

By the way, what's the difference between pkg/gadgets/run and pkg/operators/ebpf? Is the latter meant for use on k8s?
And for future uprobe features, do I need to implement changes in both places?

@flyth
Copy link
Member Author

flyth commented Mar 28, 2024

Looks good to me, thanks. The code here is identical to #2580.

I'd change authorship to you in that case - or do you want to open a PR yourself?

By the way, what's the difference between pkg/gadgets/run and pkg/operators/ebpf? Is the latter meant for use on k8s?
And for future uprobe features, do I need to implement changes in both places?

With #2512, we just merged an overhaul of the architecture regarding image based gadgets (pkg/operators/ebpf etc.) - the run gadget pkg/gadgets/run will be removed soon. So if possible, please try to migrate the code to the new operator and feel free to ask questions around it and let me know if you need any help.

@i-Pear
Copy link
Contributor

i-Pear commented Mar 28, 2024

the run gadget pkg/gadgets/run will be removed soon. So if possible, please try to migrate the code to the new operator

Thanks, I understand, will soon rebase my next PR onto pkg/operators/ebpf.

@i-Pear
Copy link
Contributor

i-Pear commented Mar 28, 2024

Let's merge this first, after that I will change my workspace to pkg/operators/ebpf.

This ports previously in the run gadget included uprobe support to the
new architecture.

Co-authored-by: Mauricio Vásquez <mauriciov@microsoft.com>
Signed-off-by: Michael Friese <mfriese@microsoft.com>
@alban
Copy link
Member

alban commented Mar 28, 2024

@flyth feel free to merge if the CI does not reveal any problems.

@flyth flyth merged commit c9f600f into main Mar 28, 2024
60 checks passed
@flyth flyth deleted the michael/oci/uprobes-1 branch March 28, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants