Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed behavior of cc2b and cc2c on test selection #59

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Changed behavior of cc2b and cc2c on test selection #59

merged 2 commits into from
Mar 4, 2024

Conversation

DanielMartinPerezdeLeon
Copy link
Contributor

Please review also the dependencies of the CC2c, i.e. when it is selected, CC2b should be deselectable.
In general, CC2c should have the same behaviour of CC2b, i.e. it depends only from CC1, so when CC2c is selected only CC1 shall be selected by default (at the moment also CC2 and CC2b are selected).

@DanielMartinPerezdeLeon
Copy link
Contributor Author

Added fix to INSPIRE-MIF/helpdesk-validator#1033.

Changed logic of metadata so cc2c works correctly.

The latest version of the validator, 2024.0, throws an error when choosing Conformance Class 2c: 'INSPIRE data sets and data set series metadata for IACS.

This error does not happen if IACS conformance class is not chosen. The error happens when running from both a local docker instance or the public instance.

@DanielMartinPerezdeLeon
Copy link
Contributor Author

Created issue to relate to this PR: #60

@DanielMartinPerezdeLeon DanielMartinPerezdeLeon changed the base branch from staging to issue-60 March 4, 2024 08:01
jenriquesoriano
jenriquesoriano approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@jenriquesoriano jenriquesoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct cc2b and cc2c behaviour.
Align EIDs for ETSs

@jenriquesoriano jenriquesoriano merged commit 2181846 into inspire-eu-validation:issue-60 Mar 4, 2024
@DanielMartinPerezdeLeon DanielMartinPerezdeLeon mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenriquesoriano jenriquesoriano jenriquesoriano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielMartinPerezdeLeon @jenriquesoriano