Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsers: relax JATS parser date handling #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szymonlopaciuk
Copy link
Contributor

Description

Don't try to add a publication date or year if not available.

Motivation and Context

Some of the test data for EDP will error the parser unnecessarily. These fields do not need to appear in a valid JATS XML, so we shouldn't assume them to be there.

Checklist:

  • I have all the information that I need (if not, move to RFC and look for it).
  • I linked the related issue(s) in the corresponding commit logs.
  • I wrote good commit log messages.
  • My code follows the code style of this project.
  • I've added any new docs if API/utils methods were added.
  • I have updated the existing documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Szymon Łopaciuk <szymon.lopaciuk@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants