APS spider: use LastRunStore spider #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michamos
reviewed
Feb 6, 2019
hepcrawl/spiders/aps_spider.py
Outdated
| @@ -199,3 +213,6 @@ def _get_authors_and_collab(self, article): | |||
|
|
|||
| def _file_name_from_url(self, url): | |||
| return "{}.xml".format(url[url.rfind('/') + 1:]) | |||
|
|
|||
| def make_file_fingerprint(self, set_): | |||
| return u'metadataPrefix={}&set={}'.format(self.format, set_) | |||
There was a problem hiding this comment.
where is the format coming from? do you really need that part? it seems OAI-PMH specific. Are you sure this really works?
vbalbp
force-pushed
the
use-LastRunStoreSpider-on-APS
branch
from
710a20c
to
0efd08a
Compare
michamos
reviewed
Feb 6, 2019
hepcrawl/spiders/aps_spider.py
Outdated
| self.message = u"Failed to load file at {} for set {}".format( | ||
| file_path, | ||
| set_, | ||
| ) |
vbalbp
force-pushed
the
use-LastRunStoreSpider-on-APS
branch
2 times, most recently
from
2307c01
to
f851cde
Compare
michamos
reviewed
Feb 7, 2019
hepcrawl/spiders/aps_spider.py
Outdated
|
|
||
| .. _See documentation here: | ||
| http://harvest.aps.org/docs/harvest-api#endpoints | ||
|
|
||
| Journals are not supported as a parameter anymore for APS Spider |
There was a problem hiding this comment.
Note:
Selecting specific journals is not supported for technical reasons as it's incompatible with the way the last run time is stored.
3a19a63
to
4e336d3
Compare
michamos
reviewed
Feb 11, 2019
| 'per_page': self.per_page, | ||
| 'date': self.date | ||
| } | ||
| return furl(APSSpider.aps_base_url).add(params).url |
There was a problem hiding this comment.
are the None checks that were done previously useless?
There was a problem hiding this comment.
I tried it out and it does matter, so changing it back to the old way with the checks
Signed-off-by: Victor Balbuena <vbalbp@gmail.com>
vbalbp
force-pushed
the
use-LastRunStoreSpider-on-APS
branch
from
4e336d3
to
93be8b3
Compare
michamos
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Victor Balbuena vbalbp@gmail.com