arXiv: cleanup parser code #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsgit
force-pushed
the
arxivparser_code_cleanup
branch
from
01d77be
to
aa033d7
Compare
* removing unused imports
* other minor code improvements
Signed-off-by: Thorsten Schwander <thorsten.schwander@gmail.com>
tsgit
force-pushed
the
arxivparser_code_cleanup
branch
from
aad0256
to
6d38d51
Compare
|
@michamos any chance this will get merged sometime ? |
michamos
reviewed
Sep 1, 2020
| @@ -357,5 +346,5 @@ def source(self): | |||
| @property | |||
| def authors_and_collaborations(self): | |||
| if not hasattr(self, '_authors_and_collaborations'): | |||
| self._authors_and_collaborations = self._get_authors_and_collaborations(self, self.root) | |||
| self._authors_and_collaborations = self._get_authors_and_collaborations(self.root) | |||
There was a problem hiding this comment.
Hi @tsgit, just noticed this PR was still open. This seems like a huge mistake that would cause an exception due to wrong number of arguments previously. Do you understand how it was working?
There was a problem hiding this comment.
Thanks for the IRL explanation!
michamos
approved these changes
Sep 1, 2020
| @@ -357,5 +346,5 @@ def source(self): | |||
| @property | |||
| def authors_and_collaborations(self): | |||
| if not hasattr(self, '_authors_and_collaborations'): | |||
| self._authors_and_collaborations = self._get_authors_and_collaborations(self, self.root) | |||
| self._authors_and_collaborations = self._get_authors_and_collaborations(self.root) | |||
There was a problem hiding this comment.
Thanks for the IRL explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thorsten Schwander thorsten.schwander@gmail.com
Description
code cleanup, removing unused imports, some whitespace and correcting an ill advised @staticmethod decorator
no functional changes
Related Issue
Motivation and Context
Checklist:
RFCand look for it).