spiders: add elsevier spider #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJedr
force-pushed
the
elsevierspider
branch
4 times, most recently
from
549ec82
to
6887d9f
Compare
pazembrz
reviewed
Sep 21, 2020
MJedr
force-pushed
the
elsevierspider
branch
6 times, most recently
from
7e1bfb3
to
d54acc7
Compare
michamos
reviewed
Sep 21, 2020
MJedr
force-pushed
the
elsevierspider
branch
from
d54acc7
to
39fe794
Compare
michamos
reviewed
Sep 22, 2020
MJedr
force-pushed
the
elsevierspider
branch
3 times, most recently
from
465fa6d
to
1d93ef0
Compare
michamos
reviewed
Sep 24, 2020
MJedr
force-pushed
the
elsevierspider
branch
5 times, most recently
from
4b02edd
to
f2b0fca
Compare
michamos
reviewed
Sep 25, 2020
hepcrawl/spiders/elsevier.py
Outdated
Comment on lines
200
to
206
| def parse_record(self, record): | ||
| """Parse an elsevier XML exported file into a HEP record.""" | ||
| with open(record, "r") as f: | ||
| elsevier_record = f.read() | ||
|
|
||
| parser = ElsevierParser(elsevier_record) | ||
| return ParsedItem(record=parser.parse(), record_format="hep") |
There was a problem hiding this comment.
Is this one used?
What we would need is a way to reharvest a given record, but we need to be able to provide it as an input to scrapy somehow. I think you can leave it out of the current PR, as it's already taken a lot of time and it's not super-urgent, and create an issue for this so we don't forget it.
michamos
reviewed
Sep 25, 2020
MJedr
force-pushed
the
elsevierspider
branch
from
f2b0fca
to
70ed16a
Compare
MJedr
force-pushed
the
elsevierspider
branch
2 times, most recently
from
92ecb01
to
c3c1f3a
Compare
michamos
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: inspirehep/inspirehep#1212