Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aps parser: handle missing affiliations gracefully #294

Merged
merged 1 commit into from
Oct 28, 2020
Merged

aps parser: handle missing affiliations gracefully #294

merged 1 commit into from
Oct 28, 2020

Conversation

MJedr
Copy link
Contributor

@MJedr MJedr commented Oct 27, 2020

michamos
michamos reviewed Oct 27, 2020
View reviewed changes
Copy link
Contributor

@michamos michamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you edit one of the existing test cases to "fake" the isuse? I think it would be better to use a real record so we keep track of real problems.

@MJedr
Copy link
Contributor Author

MJedr commented Oct 27, 2020

Yes, I've changed the reference id assigned to one of the authors for not existing one. If that's important to keep the original records I can create the mock one for tests or just leave tests as they are.

@michamos
Copy link
Contributor

you could use 10.1103/PhysRevD.102.014505 which exhibits this issue.

@MJedr MJedr merged commit be5be0a into inspirehep:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michamos michamos michamos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MJedr @michamos