Skip to content

Commit

Permalink
add publisher correction to erratum keywords
Browse files Browse the repository at this point in the history
  • Loading branch information
nooraangelva committed May 2, 2022
1 parent 4870acd commit 704d10e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion inspire_json_merger/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def is_manual_merge(head, update):


def is_erratum(update):
erratum_keywords = {"erratum", "corrigendum", "publisher's note"}
erratum_keywords = {"erratum", "corrigendum", "publisher's note", "publisher correction"}
journal_titles_list = get_value(update, "titles.title", [])
journal_titles_string = " ".join(journal_titles_list).lower()
title_contains_erratum_keyword = any([keyword in journal_titles_string for keyword in erratum_keywords])
Expand Down
14 changes: 13 additions & 1 deletion tests/unit/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,17 @@ def erratum_3():
}


@pytest.fixture
def erratum_4():
return {
'_collections': ['literature'],
'document_type': ['article'],
'titles': [{'title': 'Publisher correction A title'}],
'dois': [{'value': '10.1023/A:1026654312961'}],
'acquisition_source': {'source': 'ejl'}
}


def test_get_head_source_freetext_pub_info_with_eprint(rec_publication_info):
# record has pubinfo_freetext and arxiv_eprints, no dois
validate_subschema(rec_publication_info)
Expand Down Expand Up @@ -254,14 +265,15 @@ def test_get_head_source_arxiv_dois_and_freetext_but_no_arxiv_eprint(rec_dois, r
assert get_head_source(rec_dois) == 'publisher'


def test_get_configuration(arxiv_record, publisher_record, erratum_1, erratum_2, erratum_3):
def test_get_configuration(arxiv_record, publisher_record, erratum_1, erratum_2, erratum_3, erratum_4):
assert get_configuration(arxiv_record, arxiv_record) == ArxivOnArxivOperations
assert get_configuration(arxiv_record, publisher_record) == PublisherOnArxivOperations
assert get_configuration(publisher_record, arxiv_record) == ArxivOnPublisherOperations
assert get_configuration(publisher_record, publisher_record) == PublisherOnPublisherOperations
assert get_configuration(publisher_record, erratum_1) == ErratumOnPublisherOperations
assert get_configuration(publisher_record, erratum_2) == ErratumOnPublisherOperations
assert get_configuration(publisher_record, erratum_3) == ErratumOnPublisherOperations
assert get_configuration(publisher_record, erratum_4) == ErratumOnPublisherOperations

arxiv1 = arxiv_record
arxiv1['control_number'] = 1
Expand Down

0 comments on commit 704d10e

Please sign in to comment.