Merge pull request #108 from oguzdemirbasci/remove-publication-info-a…

…rchive-on-pub config: do not update publication_info from arxiv when published
inspirehep · Oct 29, 2021 · cc9645a · cc9645a
2 parents 97a77fc + ebeac96
commit cc9645a
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 1 deletion.
diff --git a/inspire_json_merger/config.py b/inspire_json_merger/config.py
@@ -161,7 +161,6 @@ class ArxivOnPublisherOperations(MergerConfigurationOperations):
         'figures': U.KEEP_UPDATE_AND_HEAD_ENTITIES_UPDATE_FIRST,
         'license': U.KEEP_UPDATE_AND_HEAD_ENTITIES_HEAD_FIRST,
         'public_notes': U.KEEP_UPDATE_AND_HEAD_ENTITIES_HEAD_FIRST,
-        'publication_info': U.KEEP_UPDATE_AND_HEAD_ENTITIES_HEAD_FIRST,
         'report_numbers': U.KEEP_UPDATE_AND_HEAD_ENTITIES_HEAD_FIRST,
         'titles': U.KEEP_UPDATE_AND_HEAD_ENTITIES_HEAD_FIRST,
     }

diff --git a/tests/unit/test_merger.py b/tests/unit/test_merger.py
@@ -407,3 +407,58 @@ def test_merging_cleans_acquisition_source_for_arxiv_on_publisher(fake_get_confi
 
     merged, conflict = merge(root, head, update)
     assert merged['acquisition_source']['source'] == 'arXiv'
+
+
+@patch(
+    "inspire_json_merger.api.get_configuration", return_value=ArxivOnPublisherOperations
+)
+def test_merging_publication_info_for_arxiv_on_publisher(fake_get_config):
+    root = {
+        "publication_info": [
+            {
+                "year": 2021,
+                "artid": "051701",
+                "material": "publication",
+                "journal_issue": "5",
+                "journal_title": "root title",
+                "journal_record": {
+                    "$ref": "https://inspirehep.net/api/journals/1613970"
+                },
+                "journal_volume": "104",
+            }
+        ]
+    }
+    head = {
+        "publication_info": [
+            {
+                "year": 2021,
+                "artid": "051701",
+                "material": "publication",
+                "journal_issue": "5",
+                "journal_title": "head title",
+                "journal_record": {
+                    "$ref": "https://inspirehep.net/api/journals/1613970"
+                },
+                "journal_volume": "104",
+            }
+        ]
+    }
+    update = {
+        "publication_info": [
+            {
+                "year": 2021,
+                "artid": "051701",
+                "material": "publication",
+                "journal_issue": "5",
+                "journal_title": "update title",
+                "journal_record": {
+                    "$ref": "https://inspirehep.net/api/journals/1613970"
+                },
+                "journal_volume": "104",
+            }
+        ]
+    }
+
+    merged, conflict = merge(root, head, update)
+    assert len(merged['publication_info']) == 1
+    assert merged['publication_info'][0]['journal_title'] == 'head title'