Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

540 services: ArXiV #10

Merged
merged 2 commits into from
May 8, 2018
Merged

540 services: ArXiV #10

merged 2 commits into from
May 8, 2018

Conversation

szymonlopaciuk
Copy link
Contributor

@szymonlopaciuk szymonlopaciuk commented May 8, 2018 •
edited

  • introduce an ArXiV service

@szymonlopaciuk szymonlopaciuk force-pushed the services branch 2 times, most recently from f6969cd to ab82c1b Compare May 8, 2018 11:45
@coveralls
Copy link

coveralls commented May 8, 2018 •
edited

Pull Request Test Coverage Report for Build 61

  • 18 of 18 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 91.667%
Totals Coverage Status
Change from base Build 56: 0.3%
Covered Lines: 198
Relevant Lines: 216
💛 - Coveralls

@szymonlopaciuk szymonlopaciuk force-pushed the services branch 2 times, most recently from 1b28f75 to 2f9a8d7 Compare May 8, 2018 12:40
@szymonlopaciuk
540 services: create an ArXiV service
c5cc8e1 
Sem-Ver: new feature
Signed-off-by: Szymon Łopaciuk <szymon.lopaciuk@cern.ch>
@szymonlopaciuk
global: service list of classes in dispatcher
754f988 
Signed-off-by: Szymon Łopaciuk <szymon.lopaciuk@cern.ch>
ammirate
ammirate approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@ammirate ammirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go with this 👍

@szymonlopaciuk szymonlopaciuk merged commit b3dc134 into inspirehep:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammirate ammirate ammirate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szymonlopaciuk @coveralls @ammirate