setup: enable PyPI releasing #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonlopaciuk
force-pushed
the
pypy_releasing
branch
from
ea9cfef
to
cf5446f
Compare
david-caro
reviewed
May 14, 2018
| scripts = scripts/vcr_convert.py | ||
|
|
||
| [options.package_data] | ||
| * = AUTHORS, CHANGELOG, entrypoint.py |
There was a problem hiding this comment.
We need also the MANIFEST.in, for example: https://github.com/david-caro/python-foreman/blob/master/MANIFEST.in
Signed-off-by: Szymon Łopaciuk <szymon.lopaciuk@cern.ch>
szymonlopaciuk
force-pushed
the
pypy_releasing
branch
from
cf5446f
to
78aab17
Compare
turtle321
reviewed
May 15, 2018
| zip_safe=False, | ||
| include_package_data=True, | ||
| platforms='any', | ||
| url='https://github.com/inspirehep/inspire-mitmproxy', | ||
| install_requires=install_requires, | ||
| tests_require=tests_require, | ||
| setup_requires=setup_requires, | ||
| extras_require=extras_require, |
There was a problem hiding this comment.
I believe that with the current configuration the test folder will be included in the generated artifact. We could improve this config to exclude it.
There was a problem hiding this comment.
As discussed IRL, tests are not actually added to the package
turtle321
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Szymon Łopaciuk szymon.lopaciuk@cern.ch