Add aff query #103
Merged
Add aff query #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
monaawi
force-pushed
the
add_aff_query
branch
from
1a87d55
to
8054080
Compare
drjova
reviewed
Dec 7, 2018
| @@ -708,6 +709,10 @@ def visit_value(self, node, fieldnames=None): | |||
| elif ElasticSearchVisitor.KEYWORD_TO_ES_FIELDNAME['type-code'] == fieldnames: | |||
| return self._generate_type_code_query(node.value) | |||
|
|
|||
| elif ElasticSearchVisitor.KEYWORD_TO_ES_FIELDNAME['affiliation'] == fieldnames: | |||
| query = generate_match_query(ElasticSearchVisitor.KEYWORD_TO_ES_FIELDNAME['affiliation'], node.value, with_operator_and=True) | |||
There was a problem hiding this comment.
Suggested change
| query = generate_match_query(ElasticSearchVisitor.KEYWORD_TO_ES_FIELDNAME['affiliation'], node.value, with_operator_and=True) | |
| query = generate_match_query( | |
| ElasticSearchVisitor.KEYWORD_TO_ES_FIELDNAME['affiliation'], | |
| node.value, | |
| with_operator_and=True | |
| ) |
drjova
reviewed
Dec 7, 2018
tests/test_elastic_search_visitor.py
Outdated
|
|
||
|
|
||
| def test_affiliation_query(): | ||
| query_str = 'aff:CERN' |
There was a problem hiding this comment.
what about the other cases?
inspire-query-parser/inspire_query_parser/config.py
Lines 40 to 43 in f201b6e
There was a problem hiding this comment.
The query parser transforms all the shortcuts to 'affiliation' a step before visiting value so all the cases are covered but I will add them in the test
monaawi
force-pushed
the
add_aff_query
branch
from
8054080
to
d4a10a5
Compare
monaawi
force-pushed
the
add_aff_query
branch
2 times, most recently
from
e35f3ad
to
aaaa093
Compare
Added special query for affiliations
monaawi
force-pushed
the
add_aff_query
branch
from
aaaa093
to
50df6ba
Compare
pazembrz
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added special query for affiliations