Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scripts/generate_example_records.js work out of the box #12

Closed
4 tasks done
jacquerie opened this issue Oct 5, 2016 · 0 comments
Closed
4 tasks done

Make scripts/generate_example_records.js work out of the box #12

jacquerie opened this issue Oct 5, 2016 · 0 comments

Comments

@jacquerie
Copy link
Contributor

jacquerie commented Oct 5, 2016 •
edited
Loading

  • Add a package.json with the dependencies Overkill, it's just one dependency.
  • Amend .gitignore to exclude node_modules
  • Make scripts/generate_example_records.json executable
  • Add missing requires
spirosdelviniotis pushed a commit to spirosdelviniotis/inspire-schemas that referenced this issue Oct 7, 2016
@jacquerie @spirosdelviniotis
scripts: fix generate_example_records
38f2721 
* Makes `scripts/generate_example_records.js` work out of the box
  by adding the proper requires and making it executable (closes inspirehep#12).

* Also adds `node_modules` to `.gitignore` so that we can `npm install
  json-schema-faker` locally.

Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacquerie