hep: Insertion of fields $schema and control_number in hep.json.
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
hep_schema_modification
branch
from
f8dc4c1
to
3802950
Compare
jmartinm
reviewed
Oct 27, 2016
| @@ -254,6 +258,9 @@ | |||
| "type": "array", | |||
| "uniqueItems": true | |||
| }, | |||
| "control_number": { | |||
| "type": "string" | |||
There was a problem hiding this comment.
I think it should be number. Zenodo also uses a field to store this old Invenio identifiers and defined them as numbers - https://github.com/zenodo/zenodo/blob/master/zenodo/modules/records/jsonschemas/records/record-v1.0.0.json
|
Apart from the comment, LGTM. |
* Insertion of the `$schema` and `control_number` fields in the hep schema as it is required for using invenio-records-rest PUT request upon updating a single record. Signed-off-by: Zacharias Zacharodimos <zacharias.zacharodimos@cern.ch>
zzacharo
force-pushed
the
hep_schema_modification
branch
from
3802950
to
8217432
Compare
* Insertion of the `$schema` and `control_number` fields in the hep schema as it is required for using invenio-records-rest PUT request upon updating a single record. Signed-off-by: Zacharias Zacharodimos <zacharias.zacharodimos@cern.ch>
…/inspire-schemas into hep_schema_modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$schemaandcontrol_numberfields in the hep schemaas it is required for using invenio-records-rest PUT request upon updating
a single record.
Signed-off-by: Zacharias Zacharodimos zacharias.zacharodimos@cern.ch