Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin json schema #355

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Pin json schema #355

merged 1 commit into from
Feb 27, 2019

Conversation

monaawi
Copy link
Contributor

@monaawi monaawi commented Feb 27, 2019

No description provided.

@monaawi monaawi merged commit bf060cf into inspirehep:master Feb 27, 2019
@michamos
Copy link
Contributor

What's wrong with jsonschema 3.0? I don't think we should randomly pin packages without documenting why we do this, as this will cause lots of technical debt down the line.

@monaawi
Copy link
Contributor Author

monaawi commented Feb 27, 2019

It is causing tests to fail on inspire-query-parser. And the library is already pinned in inspire-next.

@michamos
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants