literature: add record params #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harunurhan
force-pushed
the
add-record-methods
branch
from
2d6a14a
to
308f862
Compare
michamos
requested changes
May 10, 2019
| @@ -222,6 +223,7 @@ def add_author(self, author): | |||
|
|
|||
| @filter_empty_parameters | |||
| def make_author(self, full_name, | |||
| record=None, | |||
There was a problem hiding this comment.
you should add it at the end, otherwise it breaks when using positional args, and update the docstring.
There was a problem hiding this comment.
but I hope nobody is calling it like that :)
| def add_accelerator_experiment(self, legacy_name, record=None): | ||
| """Add legacy name in accelerator experiment. | ||
|
|
||
| :type legacy_name: string |
| }] | ||
|
|
||
|
|
||
| def test_publication_info_public_note(): |
harunurhan
force-pushed
the
add-record-methods
branch
from
308f862
to
29400e0
Compare
Enables adding record objects for various fields: * publication_info: conference_record, journal_record * accelerator_experiment: record * author: record
michamos
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables adding record objects for various fields: