Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builders: fix unicode issues in LiteratureBuilder #372

Merged
merged 1 commit into from
Jul 30, 2019
Merged

builders: fix unicode issues in LiteratureBuilder #372

merged 1 commit into from
Jul 30, 2019

Conversation

michamos
Copy link
Contributor

No description provided.

@drjova
Copy link
Contributor

drjova commented Jul 30, 2019

@michamos do we have to commit all resolved json?

@michamos
Copy link
Contributor Author

whoops, my bad

@drjova
Copy link
Contributor

drjova commented Jul 30, 2019

shall we add it to .gitignore as well?

@michamos
Copy link
Contributor Author

👍 I'm already doing it

@michamos
Copy link
Contributor Author

actually those were leftovers from previous code, so not needed.

@michamos
builders: fix unicode issues in LiteratureBuilder
5f809ba 
Signed-off-by: Micha Moskovic <michamos@gmail.com>
drjova
drjova approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@drjova drjova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests for

@michamos michamos merged commit 4072767 into inspirehep:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drjova drjova drjova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michamos @drjova