Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiments: add inspire_classification instead of class number #401

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

MJedr
Copy link
Contributor

@MJedr MJedr commented Jun 9, 2020

  • INSPIR-3603

@michamos
Copy link
Contributor

michamos commented Jun 9, 2020

In theory this is an incompatible change, so the major version should be bumped, but this should affect only inspire-dojson (for experiments) and inspirehep itself (where we lock packages), so I think it's ok if we bump only the minor version (with sem-ver: new feature in the commit message), otherwise we'll need to bump a lot of other packages (hepcrawl, query-parser, matcher, merger, etc.). WDYT @drjova ?

@drjova
Copy link
Contributor

drjova commented Jun 9, 2020

@michamos sounds good

Copy link
Contributor

@michamos michamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sem-ver thing should be in the commit message, not the title, see 84b8b0a

inspire_schemas/records/experiments.yml Outdated Show resolved Hide resolved
inspire_schemas/records/experiments.yml Outdated Show resolved Hide resolved
@michamos michamos merged commit 94f6db9 into inspirehep:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants