Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json_reference: create separate schema for each record type #414

Merged
merged 1 commit into from Nov 25, 2020
Merged

json_reference: create separate schema for each record type #414

merged 1 commit into from Nov 25, 2020

Conversation

MJedr
Copy link
Contributor

@MJedr MJedr commented Nov 24, 2020

No description provided.

michamos
michamos reviewed Nov 24, 2020
View reviewed changes
inspire_schemas/records/experiments.yml Outdated Show resolved Hide resolved
inspire_schemas/records/experiments.yml Outdated Show resolved Hide resolved
inspire_schemas/records/elements/related_record.yml Outdated Show resolved Hide resolved
inspire_schemas/records/hep.yml Outdated Show resolved Hide resolved
inspire_schemas/utils.py Show resolved Hide resolved
inspire_schemas/utils.py Show resolved Hide resolved
inspire_schemas/utils.py Outdated Show resolved Hide resolved
inspire_schemas/utils.py Outdated Show resolved Hide resolved
inspire_schemas/utils.py Outdated Show resolved Hide resolved
inspire_schemas/utils.py Outdated Show resolved Hide resolved
@MJedr MJedr force-pushed the refs branch 2 times, most recently from 8d3dcc1 to c52b80b Compare November 25, 2020 13:02
michamos
michamos reviewed Nov 25, 2020
View reviewed changes
inspire_schemas/utils.py Outdated Show resolved Hide resolved
inspire_schemas/utils.py Outdated Show resolved Hide resolved
tests/unit/test_utils.py Outdated Show resolved Hide resolved
tests/unit/test_utils.py Outdated Show resolved Hide resolved
michamos
michamos reviewed Nov 25, 2020
View reviewed changes
inspire_schemas/utils.py Outdated Show resolved Hide resolved
@MJedr MJedr force-pushed the refs branch 2 times, most recently from 028397a to 202739a Compare November 25, 2020 13:23
michamos
michamos reviewed Nov 25, 2020
View reviewed changes
inspire_schemas/utils.py Outdated Show resolved Hide resolved
michamos
michamos approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@michamos michamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of small things remaining, ok after fixing them 👍

inspire_schemas/utils.py Outdated Show resolved Hide resolved
inspire_schemas/utils.py Outdated Show resolved Hide resolved
@MJedr MJedr merged commit cac063c into inspirehep:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michamos michamos michamos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MJedr @michamos