Refactor the field_categories #44
Conversation
rikirenz
force-pushed
the
move-category-field
branch
7 times, most recently
from
3611e03
to
519b13d
Compare
rikirenz
changed the title
rikirenz
force-pushed
the
move-category-field
branch
4 times, most recently
from
0d43f68
to
485cb31
Compare
|
Ready for review! @david-caro |
|
|
||
|
|
||
| function resolve_schema(unresolved_schema, base_path, definitions) { | ||
| definitions = set_definitions(unresolved_schema['definitions'], definitions); |
There was a problem hiding this comment.
I would use select/pick instead of set for the name of the method, as usually the methods that have 'set' on the name are expected to modify on of the parameters or some global, setting a property on them.
| delete(resolved_element_schema['$schema']) | ||
| return resolved_element_schema | ||
| } else if (key === '$ref' && typeof(unresolved_schema[key]) === 'string' && unresolved_schema[key][0] === '#') { | ||
| return definitions |
There was a problem hiding this comment.
shouldn't this return resolve_schema(extract_definition(definitions, defs_path), schema_path, definitions)? Where the defs_path is the path part of the '#key1/key2' and the extract_definiton just extracts the value for the key it references?
There was a problem hiding this comment.
Is it possible to have a $ref statement in the definitions obj?
rikirenz
force-pushed
the
move-category-field
branch
from
485cb31
to
ba6bac0
Compare
|
|
||
|
|
||
| function resolve_schema(unresolved_schema, base_path, definitions) { | ||
| definitions = pick_definitions(unresolved_schema['definitions'], definitions); |
There was a problem hiding this comment.
definitions = unresolved_schema['definitions'] || definitions
|
|
||
|
|
||
| function extract_definition(definitions_object, defs_path) { | ||
| keys_array = defs_path.split('/'); |
rikirenz
force-pushed
the
move-category-field
branch
3 times, most recently
from
fd433e9
to
f59e85c
Compare
|
I think you can merge! |
rikirenz
force-pushed
the
move-category-field
branch
from
f59e85c
to
98cc337
Compare
|
you should rebase on latest master too, to get rid of that extra commit that's shown. |
rikirenz
force-pushed
the
move-category-field
branch
5 times, most recently
from
d37d14f
to
2283686
Compare
|
@david-caro rebased and tests have passed. |
* INCOMPATIBLE split field_categories in 2 new fields. * Remove field_categories field. * Add inspire_field_categories. * Add external_field_categories.
rikirenz
force-pushed
the
move-category-field
branch
from
2283686
to
dd57da6
Compare
This change is:
field_categoriesexternal_field_categoriesandinspire_field_categoriesIn order to maintain different lists for the categories of INSPIRE and the categories that we receive from external sites, during the articles collection