holdingpen: select all toggle fix

* Fixes select all toggling which was pushing strings to the selected
  array instead of integers. This was later causing misbehaviour when
  applying batch actions. (closes inspirehep/inspire-next#2579)

Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>

src/inspirehep-holdingpen-js/holdingpen/holdingpen.controllers.js

@@ -55,10 +55,10 @@
         _remove_record_method(record);
         $scope.vm.selected_records.splice(getItemIdx(+record._id), 1);
         if (_data_type in $scope.vm.selected_record_decisions) {
-          $scope.vm.selected_record_decisions[_data_type].splice(
-            $scope.vm.selected_record_decisions[_data_type].indexOf(+record._id),
-            1
-          );
+          var record_idx = $scope.vm.selected_record_decisions[_data_type].indexOf(+record._id);
+          if (record_idx !== -1) {
+            $scope.vm.selected_record_decisions[_data_type].splice(record_idx, 1);
+          }
         }
       } else {
         _add_record_method(record);
@@ -90,7 +90,7 @@
                 $scope.vm.selected_record_decisions[record._source._workflow.data_type] = [];
               }
               if (record._source._extra_data === undefined || record._source._extra_data.user_action === undefined) {
-                $scope.vm.selected_record_decisions[record._source._workflow.data_type].push(record._id);
+                $scope.vm.selected_record_decisions[record._source._workflow.data_type].push(+record._id);
               }
             }
           }