This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
Split utils in extras and mapping, and test the latter #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also: this ups the coverage to a respectable 92%. I think it's time to release on PyPI! |
added 2 commits
October 6, 2015 18:42
Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@cern.ch>
Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@cern.ch>
|
Excellent 👍 I will prepare a release this week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You might ask: why is the dictionary included in the code, instead of being pickled and retrieved as a fixture?
The idea is that a change in the logic in
mapping.pywill correspond to a change inside of the dictionary. In this way, the change can be inspected in the PR, instead of being inside an opaque binary object.