Add support for python3, remove support for python2 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
reviewed
Jan 30, 2020
|
|
||
| assert path == plotextractor.output_utils.get_image_location( | ||
| image, | ||
| six.text_type(tmpdir), |
There was a problem hiding this comment.
We don't need it anymore at all, but it's also not harmful at all. Please notice that it's in many places and I didn't want to loose time on removing it. Of course I can do it if you wish.
pazembrz
force-pushed
the
py3
branch
2 times, most recently
from
b36fcd0
to
a11e105
Compare
drjova
approved these changes
Feb 4, 2020
michamos
reviewed
Feb 4, 2020
| @@ -40,6 +39,18 @@ def test_get_image_location_ok(tmpdir): | |||
| ) | |||
|
|
|||
|
|
|||
| def test_get_image_location_unicode_path_ok(tmpdir): | |||
There was a problem hiding this comment.
can you also add a test where you put a file path that is not valid UTF-8?
michamos
reviewed
Feb 4, 2020
plotextractor/converter.py
Outdated
|
|
||
| import os | ||
| import tarfile | ||
| import re | ||
|
|
||
| from time import time | ||
|
|
||
| from subprocess32 import check_output, TimeoutExpired | ||
| from subprocess32 import check_output |
There was a problem hiding this comment.
Suggested change
| from subprocess32 import check_output | |
| from subprocess import check_output |
subprocess32 is a backport of python 3 subprocess to python 2.
pazembrz
force-pushed
the
py3
branch
2 times, most recently
from
6928b02
to
856e10c
Compare
Sem-Ver: api-breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.