This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Implement context menu for record nav (fix #65) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement tree-menu and tree-menu-item components. * Implement window-href service that gets window.location.href. * Set value path as an id to each component in order to navigate via #. * Introduce shared dom-utils service with focus, select and flash utilities. * Focus the first input child when navigated to a component. * Implement shallow search for menu and navigation by typing.
1 similar comment
| } | ||
|
|
||
| .flash { | ||
| border: 2px solid yellow; | ||
| } |
There was a problem hiding this comment.
I think you should configure your editor to add newlines at the end of files :)
There was a problem hiding this comment.
It will be in another pr where I fix tslint errors (which also forces to add new-line at the end of *.ts files.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIFS
You can search things, and navigate to them by
enterif you give the exact path.Clicking things works too.