refactor to avoid use of globally defined variables #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- instead pass the variables needed by each function
Stedders
reviewed
Dec 9, 2020
| @@ -140,21 +146,23 @@ def start_program_flow(): | |||
|
|
|||
| print("------ Start ------") | |||
|
|
|||
| create_local_git_repo() | |||
| access_token, repo_name, first_file, msg, github_name, pc_directory, repo_directory, run_cmd = setup_config() | |||
Stedders
reviewed
Dec 9, 2020
| first_file = config.get('your_settings', 'commit_file') | ||
| msg = config.get('your_settings', 'first_commit_msg') | ||
| github_name = config.get('your_settings', 'github_name') | ||
| def setup_config(): |
There was a problem hiding this comment.
@funbeedev - how about passing the config file in to the function as well...
def setup_config(config_file = None):
if config_file is None:
config_file = 'config.ini'Default to None is the standard way of defaulting parameters.
|
That looks good, my one small suggestions would be to make the file configurable and default to your standard value. |
|
@Stedders Thanks for the review! I'll be making the file configurable in a separate PR 👍🏿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this pull request template before submitting
1. This pull request resolves #11
2. Description
Removed use of global variables.
Config file reading performed in a function.
Variables are now passed into each function as needed.
3. Fill in checklist by marking [x]