Add tests and rename Label -> Nantes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
min
reviewed
Jan 16, 2019
Nantes/NantesLabel.swift
Outdated
| context.scaleBy(x: 1.0, y: -1.0) | ||
|
|
||
| let textRange = CFRangeMake(0, attributedText.length) | ||
| let txtRect = textRect(forBounds: rect, limitedToNumberOfLines: numberOfLines) |
There was a problem hiding this comment.
It collides with textRect(forBounds: :(
There was a problem hiding this comment.
I renamed it to limitedRect
There was a problem hiding this comment.
could always do let textRect = self.textRect(... right?
added 2 commits
January 16, 2019 08:35
min
reviewed
Jan 16, 2019
min
reviewed
Jan 16, 2019
min
approved these changes
Jan 16, 2019
chansen22
pushed a commit
that referenced
this pull request
Feb 27, 2019
There was an issue where if you set some custom attributes before setting attributedText on the label, it wouldn't keep those properties in the attributedString. Now when you set lineSpacing, and then set attributedText on the label, it'll pull the properties already setup and append them to the attributedString you're putting in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace TTTAttributedLabel with NantesLabel.