Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-mounting transitions #152

Open
spencerschack opened this issue May 3, 2018 · 2 comments
Open

Un-mounting transitions #152

spencerschack opened this issue May 3, 2018 · 2 comments
Assignees

Comments

@spencerschack
Copy link
Contributor

What?

Transitions (Fade, Grow, Slide) that unmount their children when they are no longer visible.

Why?

Sometimes is makes sense for content to enter and leave the DOM. For example for accessibility, you can use the autofocus attribute to declaratively focus an element when it enters the DOM.

How?

Add an unmount prop to the the transition components.

cc @Eldwick

@spencerschack
Copy link
Contributor Author

@dcocchia In order to do this, animations need to be used, and in order for animations to be used with no-jank, the keyframes must be preloaded. Should we leave this issue until that behavior in Radium is resolved or also ship a way for keyframes to be preloaded?

@dcocchia
Copy link
Member

I reached out to the Radium folks to see if they might be working toward fixing this. We'll see what they say and go from there.

FormidableLabs/radium#626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants