[A11y] Prevent tabbing to aria-hidden menu items #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarcuccio
changed the title
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 83.84% 83.84%
=======================================
Files 62 62
Lines 1300 1300
Branches 230 230
=======================================
Hits 1090 1090
Misses 159 159
Partials 51 51 |
NinjaBanjo
approved these changes
Feb 19, 2020
loganmurdock
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a Menu is aria-hidden, you can still tab to its child menu items.
aria-hidden="true"does not hide focusable elements from screen reader or keyboard users as TAB key navigation ignores this attribute.This PR sets a
tab-indexof-1to all child menu items of an aria-hidden menu.