Move remaining fragments classes into android package. (#205)

instacart · May 17, 2021 · 6540325 · 6540325
1 parent b33a72c
commit 6540325
Show file tree

Hide file tree

Showing 35 changed files with 41 additions and 63 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,11 @@
 - Move `BackCallback` into `android` package.
 - Move `FragmentLifecycleEvent` into `android.events` package.
 - Move `Integration` into `android` package.
+- Move `FragmentLifecycleCallback` into `android` package.
+- Move `FragmentComponent` into `android` package.
+- Move `FragmentContract` into `android` package.
+- Move `FragmentFlowState` into `android` package.
+- Move `FragmentFlowStore` into `android` package.
 
 ## [0.6.1] - November 18, 2020
 - Bugfix: Fix runtime ignoring `Formula.key` for the root formula.

diff --git a/formula-android-tests/src/main/java/com/instacart/formula/test/TestContract.kt b/formula-android-tests/src/main/java/com/instacart/formula/test/TestContract.kt
@@ -2,8 +2,8 @@ package com.instacart.formula.test
 
 import android.view.View
 import com.instacart.formula.R
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize

diff --git a/formula-android-tests/src/main/java/com/instacart/formula/test/TestContractWithId.kt b/formula-android-tests/src/main/java/com/instacart/formula/test/TestContractWithId.kt
@@ -2,8 +2,8 @@ package com.instacart.formula.test
 
 import android.view.View
 import com.instacart.formula.R
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize

diff --git a/formula-android-tests/src/main/java/com/instacart/formula/test/TestFragmentActivity.kt b/formula-android-tests/src/main/java/com/instacart/formula/test/TestFragmentActivity.kt
@@ -5,7 +5,7 @@ import androidx.annotation.VisibleForTesting
 import com.instacart.formula.FormulaAndroid
 import com.instacart.formula.R
 import com.instacart.formula.android.FormulaFragment
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentContract
 import com.instacart.formula.android.FragmentKey
 import com.instacart.formula.android.FormulaAppCompatActivity
 

diff --git a/formula-android-tests/src/main/java/com/instacart/formula/test/TestFragmentComponent.kt b/formula-android-tests/src/main/java/com/instacart/formula/test/TestFragmentComponent.kt
@@ -3,9 +3,9 @@ package com.instacart.formula.test
 import android.view.View
 import com.instacart.formula.RenderView
 import com.instacart.formula.Renderer
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
-import com.instacart.formula.fragment.FragmentLifecycleCallback
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
+import com.instacart.formula.android.FragmentLifecycleCallback
 
 object TestFragmentComponent {
 

diff --git a/formula-android-tests/src/main/java/com/instacart/formula/test/TestLifecycleContract.kt b/formula-android-tests/src/main/java/com/instacart/formula/test/TestLifecycleContract.kt
@@ -3,9 +3,9 @@ package com.instacart.formula.test
 import android.os.Bundle
 import android.view.View
 import com.instacart.formula.R
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
-import com.instacart.formula.fragment.FragmentLifecycleCallback
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
+import com.instacart.formula.android.FragmentLifecycleCallback
 import kotlinx.android.parcel.IgnoredOnParcel
 import kotlinx.android.parcel.Parcelize
 

diff --git a/formula-android-tests/src/test/java/com/instacart/formula/FragmentFlowRenderViewTest.kt b/formula-android-tests/src/test/java/com/instacart/formula/FragmentFlowRenderViewTest.kt
@@ -6,8 +6,8 @@ import androidx.test.core.app.ActivityScenario
 import androidx.test.ext.junit.rules.ActivityScenarioRule
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.google.common.truth.Truth.assertThat
-import com.instacart.formula.fragment.FragmentContract
-import com.instacart.formula.fragment.FragmentFlowState
+import com.instacart.formula.android.FragmentContract
+import com.instacart.formula.android.FragmentFlowState
 import com.instacart.formula.android.FragmentKey
 import com.instacart.formula.android.BackCallback
 import com.instacart.formula.test.TestContract

diff --git a/formula-android-tests/src/test/java/com/instacart/formula/FragmentLifecycleStateTest.kt b/formula-android-tests/src/test/java/com/instacart/formula/FragmentLifecycleStateTest.kt
@@ -5,7 +5,7 @@ import androidx.test.ext.junit.rules.ActivityScenarioRule
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.google.common.truth.Truth.assertThat
 import com.instacart.formula.android.FormulaFragment
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentContract
 import com.instacart.formula.android.ActivityStoreContext
 import com.instacart.formula.test.TestContract
 import com.instacart.formula.test.TestContractWithId

diff --git a/formula-android/src/main/java/com/instacart/formula/android/ActivityStore.kt b/formula-android/src/main/java/com/instacart/formula/android/ActivityStore.kt
@@ -1,8 +1,6 @@
 package com.instacart.formula.android
 
 import androidx.fragment.app.FragmentActivity
-import com.instacart.formula.fragment.FragmentFlowState
-import com.instacart.formula.fragment.FragmentFlowStore
 import com.instacart.formula.android.events.FragmentLifecycleEvent
 import io.reactivex.rxjava3.disposables.Disposable
 

diff --git a/formula-android/src/main/java/com/instacart/formula/android/ActivityStoreContext.kt b/formula-android/src/main/java/com/instacart/formula/android/ActivityStoreContext.kt
@@ -3,8 +3,6 @@ package com.instacart.formula.android
 import androidx.fragment.app.FragmentActivity
 import androidx.lifecycle.Lifecycle
 import com.instacart.formula.android.events.ActivityResult
-import com.instacart.formula.fragment.FragmentFlowState
-import com.instacart.formula.fragment.FragmentFlowStore
 import com.instacart.formula.android.events.FragmentLifecycleEvent
 import io.reactivex.rxjava3.core.Observable
 import io.reactivex.rxjava3.disposables.Disposable

diff --git a/formula-android/src/main/java/com/instacart/formula/android/Feature.kt b/formula-android/src/main/java/com/instacart/formula/android/Feature.kt
@@ -1,7 +1,6 @@
 package com.instacart.formula.android
 
 import io.reactivex.rxjava3.core.Observable
-import com.instacart.formula.fragment.FragmentFlowStore
 
 /**
  * Feature is based on uni-directional state management where a single state model drives

diff --git a/formula-android/src/main/java/com/instacart/formula/android/FeatureFactory.kt b/formula-android/src/main/java/com/instacart/formula/android/FeatureFactory.kt
@@ -1,7 +1,5 @@
 package com.instacart.formula.android
 
-import com.instacart.formula.fragment.FragmentFlowStore
-
 /**
  * Feature factory is responsible for creating a [Feature] for a specific [fragment key][Key].
  *

diff --git a/formula-android/src/main/java/com/instacart/formula/android/FeatureView.kt b/formula-android/src/main/java/com/instacart/formula/android/FeatureView.kt
@@ -2,7 +2,6 @@ package com.instacart.formula.android
 
 import android.view.View
 import com.instacart.formula.Cancelable
-import com.instacart.formula.fragment.FragmentLifecycleCallback
 import io.reactivex.rxjava3.core.Observable
 
 /**

diff --git a/formula-android/src/main/java/com/instacart/formula/android/FormulaFragment.kt b/formula-android/src/main/java/com/instacart/formula/android/FormulaFragment.kt
@@ -6,7 +6,6 @@ import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.Fragment
 import com.instacart.formula.Cancelable
-import com.instacart.formula.fragment.FragmentLifecycleCallback
 import com.jakewharton.rxrelay3.BehaviorRelay
 
 class FormulaFragment : Fragment(), BaseFormulaFragment<Any> {

diff --git a/formula-android/src/main/java/com/instacart/formula/android/FragmentBindingBuilder.kt b/formula-android/src/main/java/com/instacart/formula/android/FragmentBindingBuilder.kt
@@ -4,7 +4,6 @@ import com.instacart.formula.android.internal.Binding
 import com.instacart.formula.android.internal.Bindings
 import com.instacart.formula.android.internal.FunctionUtils
 import com.instacart.formula.android.views.FragmentContractViewFactory
-import com.instacart.formula.fragment.FragmentContract
 import com.instacart.formula.android.internal.FeatureBinding
 import io.reactivex.rxjava3.core.Observable
 import java.lang.IllegalStateException

diff --git a/...art/formula/fragment/FragmentComponent.kt → ...cart/formula/android/FragmentComponent.kt b/...art/formula/fragment/FragmentComponent.kt → ...cart/formula/android/FragmentComponent.kt
@@ -1,4 +1,4 @@
-package com.instacart.formula.fragment
+package com.instacart.formula.android
 
 import com.instacart.formula.Renderer
 import com.instacart.formula.RenderView

diff --git a/...cart/formula/fragment/FragmentContract.kt → ...acart/formula/android/FragmentContract.kt b/...cart/formula/fragment/FragmentContract.kt → ...acart/formula/android/FragmentContract.kt
@@ -1,7 +1,6 @@
-package com.instacart.formula.fragment
+package com.instacart.formula.android
 
 import android.view.View
-import com.instacart.formula.android.FragmentKey
 
 /**
  * Responsible for providing a [FragmentComponent]

diff --git a/...art/formula/fragment/FragmentFlowState.kt → ...cart/formula/android/FragmentFlowState.kt b/...art/formula/fragment/FragmentFlowState.kt → ...cart/formula/android/FragmentFlowState.kt
@@ -1,9 +1,4 @@
-package com.instacart.formula.fragment
-
-import com.instacart.formula.android.FragmentId
-import com.instacart.formula.android.FeatureEvent
-import com.instacart.formula.android.FragmentKey
-import com.instacart.formula.android.FragmentState
+package com.instacart.formula.android
 
 /**
  * Represents currently [activeKeys] and their [states].

diff --git a/...art/formula/fragment/FragmentFlowStore.kt → ...cart/formula/android/FragmentFlowStore.kt b/...art/formula/fragment/FragmentFlowStore.kt → ...cart/formula/android/FragmentFlowStore.kt
@@ -1,16 +1,10 @@
-package com.instacart.formula.fragment
+package com.instacart.formula.android
 
 import com.instacart.formula.Evaluation
 import com.instacart.formula.Formula
 import com.instacart.formula.FormulaContext
-import com.instacart.formula.android.FragmentId
 import com.instacart.formula.rxjava3.RxStream
 import com.instacart.formula.android.internal.Binding
-import com.instacart.formula.android.FeatureEvent
-import com.instacart.formula.android.DisposableScope
-import com.instacart.formula.android.FragmentBindingBuilder
-import com.instacart.formula.android.FragmentEnvironment
-import com.instacart.formula.android.FragmentState
 import com.instacart.formula.android.events.FragmentLifecycleEvent
 import com.instacart.formula.rxjava3.toObservable
 import com.jakewharton.rxrelay3.PublishRelay

diff --git a/...ula/fragment/FragmentLifecycleCallback.kt → ...mula/android/FragmentLifecycleCallback.kt b/...ula/fragment/FragmentLifecycleCallback.kt → ...mula/android/FragmentLifecycleCallback.kt
@@ -1,4 +1,4 @@
-package com.instacart.formula.fragment
+package com.instacart.formula.android
 
 import android.os.Bundle
 import android.view.View

diff --git a/formula-android/src/main/java/com/instacart/formula/android/ViewInstance.kt b/formula-android/src/main/java/com/instacart/formula/android/ViewInstance.kt
@@ -4,7 +4,6 @@ import android.view.View
 import com.instacart.formula.RenderView
 import com.instacart.formula.Renderer
 import com.instacart.formula.android.views.FeatureViewBindFunction
-import com.instacart.formula.fragment.FragmentLifecycleCallback
 
 /**
  * View instance contains an initialized Android [view] and provides factory

diff --git a/...-android/src/main/java/com/instacart/formula/android/internal/ActivityStoreContextImpl.kt b/...-android/src/main/java/com/instacart/formula/android/internal/ActivityStoreContextImpl.kt
@@ -3,7 +3,7 @@ package com.instacart.formula.android.internal
 import androidx.fragment.app.FragmentActivity
 import androidx.lifecycle.Lifecycle
 import com.instacart.formula.android.events.ActivityResult
-import com.instacart.formula.fragment.FragmentFlowState
+import com.instacart.formula.android.FragmentFlowState
 import com.instacart.formula.android.FragmentKey
 import com.instacart.formula.android.FragmentId
 import com.instacart.formula.android.ActivityStoreContext

diff --git a/...la-android/src/main/java/com/instacart/formula/android/internal/FragmentFlowRenderView.kt b/...la-android/src/main/java/com/instacart/formula/android/internal/FragmentFlowRenderView.kt
@@ -12,7 +12,7 @@ import com.instacart.formula.RenderView
 import com.instacart.formula.android.BaseFormulaFragment
 import com.instacart.formula.android.FormulaFragment
 import com.instacart.formula.android.FragmentEnvironment
-import com.instacart.formula.fragment.FragmentFlowState
+import com.instacart.formula.android.FragmentFlowState
 import com.instacart.formula.android.events.FragmentLifecycleEvent
 import com.instacart.formula.android.BackCallback
 import com.instacart.formula.android.FeatureEvent

diff --git a/...-android/src/main/java/com/instacart/formula/android/views/FragmentContractViewFactory.kt b/...-android/src/main/java/com/instacart/formula/android/views/FragmentContractViewFactory.kt
@@ -4,7 +4,7 @@ import com.instacart.formula.android.FeatureView
 import com.instacart.formula.android.LayoutViewFactory
 import com.instacart.formula.android.ViewFactory
 import com.instacart.formula.android.ViewInstance
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentContract
 
 /**
  * An implementation of [ViewFactory] which delegates implementation to [FragmentContract].

diff --git a/formula-android/src/test/java/com/instacart/formula/android/ActivityStoreContextTest.kt b/formula-android/src/test/java/com/instacart/formula/android/ActivityStoreContextTest.kt
@@ -3,7 +3,6 @@ package com.instacart.formula.android
 import androidx.fragment.app.FragmentActivity
 import androidx.lifecycle.Lifecycle
 import com.instacart.formula.android.internal.ActivityStoreContextImpl
-import com.instacart.formula.fragment.FragmentContract
 import com.jakewharton.rxrelay3.PublishRelay
 import com.nhaarman.mockito_kotlin.mock
 import com.nhaarman.mockito_kotlin.verify

diff --git a/formula-android/src/test/java/com/instacart/formula/android/FlowFactoryTest.kt b/formula-android/src/test/java/com/instacart/formula/android/FlowFactoryTest.kt
@@ -1,7 +1,6 @@
 package com.instacart.formula.android
 
 import com.google.common.truth.Truth
-import com.instacart.formula.fragment.FragmentFlowStore
 import com.instacart.formula.android.fakes.TestAccountFragmentContract
 import com.instacart.formula.android.fakes.TestLoginFragmentContract
 import com.instacart.formula.android.fakes.TestSignUpFragmentContract

diff --git a/formula-android/src/test/java/com/instacart/formula/android/FragmentFlowStoreTest.kt b/formula-android/src/test/java/com/instacart/formula/android/FragmentFlowStoreTest.kt
@@ -5,8 +5,6 @@ import com.instacart.formula.android.fakes.DetailKey
 import com.instacart.formula.android.fakes.FakeAuthFlowFactory
 import com.instacart.formula.android.fakes.FakeComponent
 import com.instacart.formula.android.fakes.MainKey
-import com.instacart.formula.fragment.FragmentContract
-import com.instacart.formula.fragment.FragmentFlowStore
 import com.instacart.formula.android.events.FragmentLifecycleEvent
 import com.instacart.formula.android.fakes.TestAccountFragmentContract
 import com.instacart.formula.android.fakes.TestLoginFragmentContract

diff --git a/formula-android/src/test/java/com/instacart/formula/android/fakes/DetailKey.kt b/formula-android/src/test/java/com/instacart/formula/android/fakes/DetailKey.kt
@@ -1,8 +1,8 @@
 package com.instacart.formula.android.fakes
 
 import android.view.View
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize

diff --git a/formula-android/src/test/java/com/instacart/formula/android/fakes/FakeAuthFlowFactory.kt b/formula-android/src/test/java/com/instacart/formula/android/fakes/FakeAuthFlowFactory.kt
@@ -2,7 +2,7 @@ package com.instacart.formula.android.fakes
 
 import com.instacart.formula.android.Flow
 import com.instacart.formula.android.FlowFactory
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentContract
 import com.instacart.formula.android.DisposableScope
 import io.reactivex.rxjava3.core.Observable
 

diff --git a/formula-android/src/test/java/com/instacart/formula/android/fakes/FakeComponent.kt b/formula-android/src/test/java/com/instacart/formula/android/fakes/FakeComponent.kt
@@ -1,6 +1,6 @@
 package com.instacart.formula.android.fakes
 
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentContract
 import com.instacart.formula.android.FragmentKey
 import com.instacart.formula.android.DisposableScope
 import com.jakewharton.rxrelay3.PublishRelay

diff --git a/formula-android/src/test/java/com/instacart/formula/android/fakes/MainKey.kt b/formula-android/src/test/java/com/instacart/formula/android/fakes/MainKey.kt
@@ -1,8 +1,8 @@
 package com.instacart.formula.android.fakes
 
 import android.view.View
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize

diff --git a/...-android/src/test/java/com/instacart/formula/android/fakes/TestAccountFragmentContract.kt b/...-android/src/test/java/com/instacart/formula/android/fakes/TestAccountFragmentContract.kt
@@ -1,8 +1,8 @@
 package com.instacart.formula.android.fakes
 
 import android.view.View
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize

diff --git a/...la-android/src/test/java/com/instacart/formula/android/fakes/TestLoginFragmentContract.kt b/...la-android/src/test/java/com/instacart/formula/android/fakes/TestLoginFragmentContract.kt
@@ -1,8 +1,8 @@
 package com.instacart.formula.android.fakes
 
 import android.view.View
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize

diff --git a/...a-android/src/test/java/com/instacart/formula/android/fakes/TestSignUpFragmentContract.kt b/...a-android/src/test/java/com/instacart/formula/android/fakes/TestSignUpFragmentContract.kt
@@ -1,8 +1,8 @@
 package com.instacart.formula.android.fakes
 
 import android.view.View
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize

diff --git a/formula-android/src/test/java/com/instacart/formula/android/fakes/TestTaskListContract.kt b/formula-android/src/test/java/com/instacart/formula/android/fakes/TestTaskListContract.kt
@@ -1,8 +1,8 @@
 package com.instacart.formula.android.fakes
 
 import android.view.View
-import com.instacart.formula.fragment.FragmentComponent
-import com.instacart.formula.fragment.FragmentContract
+import com.instacart.formula.android.FragmentComponent
+import com.instacart.formula.android.FragmentContract
 import kotlinx.android.parcel.Parcelize
 
 @Parcelize