Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove early fragment removal logic. #206

Merged
merged 1 commit into from
May 28, 2021
Merged

[Android] Remove early fragment removal logic. #206

merged 1 commit into from
May 28, 2021

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented May 21, 2021

What

This logic might not be needed anymore since we generate a unique identifier for each formula.

@Laimiux Laimiux requested a review from mhartvick May 21, 2021 22:44
@carrotkite
Copy link

carrotkite commented May 21, 2021 •
edited
Loading

JaCoCo Code Coverage 76.86% ✅

Class Covered Meta Status
com/instacart/formula/android/internal/FragmentFlowRenderView 75% 0% ✅

Generated by 🚫 Danger

@Laimiux Laimiux force-pushed the laimonas/remove-early-fragment-removal-logic branch from 4e7e1aa to d1ef577 Compare May 24, 2021 20:29
mhartvick
mhartvick approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@mhartvick mhartvick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this 🙇

@Laimiux Laimiux merged commit fea5956 into master May 28, 2021
@Laimiux Laimiux deleted the laimonas/remove-early-fragment-removal-logic branch May 28, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhartvick mhartvick mhartvick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Laimiux @carrotkite @mhartvick