[Android] Initial logger. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Code Coverage 76.93% ✅
Generated by 🚫 Danger |
Jawnnypoo
reviewed
May 24, 2021
| * @param onFragmentError A global handler for fragment errors. Override this to log the crashes. | ||
| */ | ||
| fun init( | ||
| application: Application, | ||
| logger: (String) -> Unit = {}, |
There was a problem hiding this comment.
Should it be nullable if the user doesn't care to log? and if so, maybe it should be the last param?
There was a problem hiding this comment.
I've made the logger nullable, however, it cannot be the last parameter because the following continuation is already occupying that spot.
activities: ActivityConfigurator.() -> Unit
Jawnnypoo
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding a hook to access debug
formula-androidevents. I will provide more events in the future, but for now, I'm only interested in ignored attach events.