updating testing and small increment dependencies #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancoisBlavoet
approved these changes
Sep 1, 2021
JaCoCo Code Coverage 77.75% ✅
Generated by 🚫 Danger |
Laimiux
reviewed
Sep 1, 2021
build.gradle
Outdated
| @@ -25,8 +25,8 @@ buildscript { | |||
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion" | |||
| classpath "com.vanniktech:gradle-android-junit-jacoco-plugin:0.16.0" | |||
| classpath "com.github.ben-manes:gradle-versions-plugin:0.36.0" | |||
| classpath "org.jetbrains.dokka:dokka-gradle-plugin:1.4.32" | |||
| classpath "org.jetbrains.dokka:android-documentation-plugin:1.4.32" | |||
| classpath "org.jetbrains.dokka:dokka-gradle-plugin:1.5.0" | |||
There was a problem hiding this comment.
I wonder if this dokka update doesn't break publishing (it's usually pretty fragile integration). Not sure how to best test without trying to run the publish task. Maybe can try to publish to local maven.
There was a problem hiding this comment.
Ah, ok. I'm going to hold off on the dokka update then for the time being and keep the rest rather than going down that hole right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this updates most of the testing dependencies along with a couple of other small incremental bumps.