Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marco fix geo ip test #155

Merged
merged 8 commits into from Feb 4, 2020
Merged

Marco fix geo ip test #155

merged 8 commits into from Feb 4, 2020

Conversation

mmontagna
Copy link
Contributor

@mmontagna mmontagna commented Feb 4, 2020 •
edited

What

Fix tests by changing geoip DB url to be a private s3 url.

Why

Fixes tests.

Shadow6363
Shadow6363 approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@Shadow6363 Shadow6363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shame Python 2 is complaining.

@mmontagna mmontagna merged commit 5773437 into master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadow6363 Shadow6363 Shadow6363 approved these changes

@montanalow montanalow Awaiting requested review from montanalow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmontagna @Shadow6363