Fix/recurrent maddpg with launchpad #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesSmit
requested review from
arnupretorius,
KaleabTessera,
KevinEloff and
jcformanek
KaleabTessera
approved these changes
May 10, 2021
| @@ -92,7 +93,7 @@ def make_networks( | |||
| observation_network, | |||
| snt.Flatten(), | |||
| snt.nets.MLP(policy_networks_layer_sizes[key]), | |||
| snt.LSTM(20), | |||
| snt.LSTM(25), | |||
There was a problem hiding this comment.
Any particular reason for this or just seeing if it improved performance?
There was a problem hiding this comment.
This was used to make it easier to debug, as now it is different than the sequence length. This can change back to 20, but I find it easier to see what is going on in the adders when something breaks if the size is not the same as the sequence length.
KevinEloff
approved these changes
May 10, 2021
arnupretorius
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix minor bugs to allow for recurrent training of MA-DDPG using Launchpad.
Why?
The bugs broke training if one used MA-DDPG with a recurrent executor.
How?
There were some minor bugs inside the MA-DDPG system, especially with the signatures, which meant incorrect data was being sent through the adders.
Extra
I also updated the transition adder to conform to the signature setup of the sequence adder.