feat: use external training state #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results34 tests - 1 34 ✔️ - 1 1m 3s ⏱️ +16s Results for commit be24cda. ± Comparison against base commit eeb9bcb. This pull request removes 9 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
cyprienc
reviewed
Jul 28, 2022
cyprienc
reviewed
Jul 29, 2022
cyprienc
reviewed
Jul 29, 2022
* test: updated convergence catx and contest * fix: fix mypy type error * test: updated test_tree * test: updated network module * docs: updated getting started guide * chore: answered review comments
cyprienc
reviewed
Aug 1, 2022
cyprienc
reviewed
Aug 1, 2022
cyprienc
reviewed
Aug 1, 2022
tests/test_catx.py
Outdated
Comment on lines
67
to
82
| if not request: | ||
| action_min = 0.0 | ||
| action_max = 1.0 | ||
| else: | ||
| action_min = request.param[0] | ||
| action_max = request.param[1] | ||
|
|
||
| return mk # type: ignore | ||
| catx = CATX( | ||
| catx_network=catx_network_with_dropout_extras, | ||
| optimizer=optax.adam(learning_rate=0.01), | ||
| discretization_parameter=4, | ||
| bandwidth=1.5 / 4, | ||
| action_min=action_min, | ||
| action_max=action_max, | ||
| ) | ||
|
|
There was a problem hiding this comment.
we can probably create a function that takes in the catx_network as parameter as well as the other fixture parameters and returns the CATX object instanciated. Since the fixtures catx and catx_with_dropout_extras differ only by the class used for the catx network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.