Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LibCst's FullyQualifiedNameProvider #255

Closed
kinto0 opened this issue Jan 24, 2023 · 0 comments
Closed

Support LibCst's FullyQualifiedNameProvider #255

kinto0 opened this issue Jan 24, 2023 · 0 comments
Assignees
@amyreese
Labels
enhancement New feature or request
Milestone
2.0

Comments

@kinto0
Copy link

kinto0 commented Jan 24, 2023

Fixit should have support for libcst's FullyQualifiedNameProvider metadata option.

this provider requires a FullRepoManager to work.
@amyreese amyreese added the enhancement New feature or request label Jan 24, 2023
@amyreese amyreese added this to the 2.0 milestone Jan 24, 2023
@amyreese amyreese self-assigned this Feb 9, 2023
@amyreese amyreese mentioned this issue Feb 23, 2023
Merged
amyreese added a commit that referenced this issue Feb 23, 2023
@amyreese
Update on "Enable FullRepoManager when lint rules need it"
8a3483b 
Looks at the list of enable lint rules, and if any of those need the
`FullyQualifiedNameProvider` metadata, and then enables the
`FullRepoManager` from libcst. The cache is then resolved and passed
through the metadata wrapper when visiting the CST, enabling rules to
use the appropriate metadata.

Requires passing the root path and file path being linted to
`FullRepoManager`, which is accomplished by passing the Fixit config
further through the API into the `CSTLintRunner` implementation.

Fixes #255 

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amyreese amyreese

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@amyreese @kinto0