Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

special character issue fixed. #636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

special character issue fixed. #636

wants to merge 1 commit into from

Conversation

Soydasm
Copy link

@Soydasm Soydasm commented Nov 28, 2021

Special characters change the endpoint URLs when the enums are converted to lowercase in the request. The response of Instagram is 404 in this situation. This happens when the device language is different than English. (i.e: Turkish)

@Soydasm
Copy link
Author

Soydasm commented Nov 28, 2021

@jvogit 6

jvogit
jvogit requested changes Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@jvogit jvogit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think a cleaner solution would be overriding the enum's toString() method to lowercase in en US locale like so:

https://stackoverflow.com/questions/19894093/print-java-enum-to-lower-case-by-default-keeping-enum-constants-in-uppercase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvogit jvogit jvogit requested changes

@codeceptionn codeceptionn codeceptionn approved these changes

@vady1212 vady1212 vady1212 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Soydasm @jvogit @codeceptionn @vady1212