This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
Code cleanup #349
Closed
Code cleanup #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o instagrambot-master
sudoguy
suggested changes
Oct 9, 2017
|
|
||
| class Bot(API): | ||
| class Bot(API, BotArchive, BotBlock, BotComment, BotDelete, |
There was a problem hiding this comment.
Wrong method resolution order. API must be in end
| super(Bot, self).__init__() | ||
|
|
||
| stop_words=None): | ||
| super(self.__class__, self).__init__() |
| delay.small_delay(self) | ||
| media = self.get_media_info(media_id) | ||
| media = media[0] if isinstance(media, list) else media | ||
| if super(self.__class__, self).archiveMedia(media, undo): |
| return False | ||
| if limits.check_if_bot_can_block(self): | ||
| delay.block_delay(self) | ||
| if super(self.__class__, self).block(user_id): |
| user_id = self.convert_to_user_id(user_id) | ||
| if limits.check_if_bot_can_unblock(self): | ||
| delay.unblock_delay(self) | ||
| if super(self.__class__, self).unblock(user_id): |
| class BotPhoto(object): | ||
| def upload_photo(self, photo, caption=None, upload_id=None): | ||
| delay.small_delay(self) | ||
| if super(self.__class__, self).uploadPhoto(photo, caption, upload_id): |
| caption = media['caption']['text'] | ||
| with open('{path}{0}_{1}.txt'.format(media['user']['username'], media_id, path=path), encoding='utf8', mode='w') as f: | ||
| f.write(caption) | ||
| photo = super(self.__class__, self).downloadPhoto( |
| return True # whitelisted user | ||
| if limits.check_if_bot_can_unfollow(self): | ||
| delay.unfollow_delay(self) | ||
| if super(self.__class__, self).unfollow(user_id): |
| def unlike(self, media_id): | ||
| if limits.check_if_bot_can_unlike(self): | ||
| delay.unlike_delay(self) | ||
| if super(self.__class__, self).unlike(media_id): |
| def upload_video(self, video, thumbnail, caption=''): | ||
| delay.small_delay(self) | ||
| self.logger.info("Started uploading '{video}'".format(video=video)) | ||
| if not super(self.__class__, self).uploadVideo(video, thumbnail, caption): |
|
@xen Will you fix the issues with the super class? Your pull request is awesome but there are several bugs that should be fixed! |
|
@xen Waiting for your fixes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I purpose with this PR:
I hope it will help to maintain and develop code in the future.