Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-commit-mode and --tagged not working together #483

Closed
orSpec opened this issue Jan 2, 2020 · 2 comments
Closed

-commit-mode and --tagged not working together #483

orSpec opened this issue Jan 2, 2020 · 2 comments
Labels
bug Bug

Comments

@orSpec
Copy link

orSpec commented Jan 2, 2020

If downloading with flags --commit-mode and --tagged, it seems that it is never checked if the post was already downloaded.

Normally, it is checked if the json exists. This check seems to be missing when downloading tagged posts or is not working properly.

@orSpec orSpec added the bug Bug label Jan 2, 2020
@aandergr
Copy link
Member

Thanks for reporting! Related to #257, in that it refers to the broken --commit-mode.

@aandergr aandergr added the leave open Not closed automatically due to inactivity label Jun 3, 2020
aandergr added a commit that referenced this issue Jun 3, 2020
--commit-mode has many bugs, especially #257, #483.  For now we discourage using
it until it is reimplemented.
@aandergr
Copy link
Member

This has been fixed by #697.

Rather than checking the json file to make sure posts have been successfully downloaded, data is stored in a temporary file which is renamed when downloading has finished.

It is merged into upcoming/v4.5, which can be tried out with:

pip3 install --upgrade git+https://github.com/instaloader/instaloader@upcoming/v4.5

@aandergr aandergr removed the leave open Not closed automatically due to inactivity label Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

No branches or pull requests

2 participants