Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--fast-update --highlights crash if cover.jpg exist #769

Closed
psonnosp opened this issue Aug 13, 2020 · 4 comments · Fixed by #775
Closed

--fast-update --highlights crash if cover.jpg exist #769

psonnosp opened this issue Aug 13, 2020 · 4 comments · Fixed by #775
Labels
bug Bug Windows Problem originates from using Microsoft Windows

Comments

@psonnosp
Copy link

Describe the bug
If you already have downloaded highlights from a profile and try to do it again the session crash because cover.jpg already exist. If you delete cover.jpg everything works as expected.

To Reproduce
Steps to reproduce the behavior:
.\instaloader profile(s) --fast-update --highlights --no-posts --no-profile-pic --no-metadata-json -l "username"
Then do it again when the highlight has new content.

Expected behavior
That it skips cover.jpg and download the new content.

Error messages and tracebacks
2020-02-08_21-14-02_UTC_cover.jpg Traceback (most recent call last):
File "main.py", line 462, in
File "main.py", line 459, in __main
File "main.py", line 429, in main
File "main.py", line 203, in _main
File "instaloader\instaloader.py", line 1149, in download_profiles
File "instaloader\instaloader.py", line 63, in call
File "instaloader\instaloader.py", line 707, in download_highlights
File "instaloader\instaloader.py", line 429, in download_highlight_cover
File "instaloader\instaloader.py", line 79, in call
File "instaloader\instaloader.py", line 416, in download_title_pic
File "instaloader\instaloadercontext.py", line 490, in write_raw
FileExistsError: [WinError 183] Cannot create a file when that file already exists: '2020-02-08_21-
14-02_UTC_cover.jpg.temp' -> '2020-02-08_21-14-02_UTC_cover.jpg'

Instaloader version
4.5

Additional context
Add any other context about the problem here.

@psonnosp psonnosp added the bug Bug label Aug 13, 2020
@bebunw
Copy link

bebunw commented Aug 15, 2020

i confirm the same bug, it does not update highlight because script stop after detecting cover.jpg of highlights that already exists

@psonnosp
Copy link
Author

Will that commit also fix the same thing happening to profile_pic? Cause now all of a sudden I get the same thing there.

@aandergr aandergr added the Windows Problem originates from using Microsoft Windows label Aug 17, 2020
@aandergr aandergr linked a pull request Aug 17, 2020 that will close this issue
@psonnosp
Copy link
Author

Thank you!
And to answer myself it seem to have fixed them both.

@aandergr
Copy link
Member

Fixed in Version 4.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug Windows Problem originates from using Microsoft Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants