Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loop when receiving comments #1347

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Endless loop when receiving comments #1347

merged 1 commit into from
Nov 27, 2021

Conversation

JeremyKj87
Copy link
Contributor

Test data: https://www.instagram.com/p/CVyEdhbIXPG/

  • The changes proposed in this pull request

  • change the nodeiterator next method to check if the response is the same than before

  • The completeness of this change

    • Is it just a proof of concept? It's just a poc
    • Can we help you at some point?

@Thammus Thammus merged commit 815ba83 into instaloader:master Nov 27, 2021
@Thammus
Copy link
Member

Thammus commented Nov 27, 2021

The change looks good and works fine 🌈. Many thanks for fixing this recurring bug 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post.get_comments() creates an infinite loop, fetching same comment
2 participants