Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug with connecting to the agent #18

Merged
merged 1 commit into from Sep 15, 2017
Merged

Fixes a bug with connecting to the agent #18

merged 1 commit into from Sep 15, 2017

Conversation

elgris
Copy link
Contributor

@elgris elgris commented Sep 15, 2017

Basically, it fixes 2 pieces:

  1. Hanging shell call in Docker container (as discovered, we need a shell=True there). Also the command itself was taken from golang sensor
  2. One small bug when value must be updated before the condition

@pglombardo
Copy link
Contributor

pglombardo commented Sep 15, 2017

A debug log issue surfaced in python 3.6.2. I'll fix in a separate PR before release:
https://travis-ci.org/instana/python-sensor/jobs/275808812

@pglombardo pglombardo merged commit 481bf86 into instana:master Sep 15, 2017
@elgris
Copy link
Contributor Author

elgris commented Sep 15, 2017

thanks @pglombardo !
For me changing a line fsm.py:86 from

proc.stdout.read()

to

str(proc.stdout.read())

fixed Python3 tests

@pglombardo
Copy link
Contributor

That might be the more appropriate place. I did the same just in the actual debug line in check_host with str().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants